BUG: Fix typo in version file path#37
Conversation
|
Thanks @cduvallet! Your change looks right, we're just wondering why we didn't catch it sooner. Let's test this out with this change, and perhaps add a new test to the CI that would have caught the error. (We'll do all of this - nothing else needed from you right now @cduvallet.) |
|
Hey @cduvallet you're totally right, thanks for catching this! 🙌🏼 @gregcaporaso the reason this hasn't come up is because this is a very subtle issue that we likely wouldn't notice ourselves unless we ran into the following sequence of conditions:
I had to do some digging but it looks like I actually did run into this during the pyproject.toml migration (because I did use the plugin template and copier in a github action to bulk update all of the plugins) and ended up having to fix the version filepath, but I must have missed getting this updated after the fact. There isn't really a great way to add a test for this, but this change should be sufficient to ensure correct python versioning moving forward. |
|
Thanks @lizgehret, and thanks again for catching this @cduvallet! |
I'm not 100% sure what's going on with the versioning, but I'm pretty sure this is a typo? Please ignore if I am wrong and confused!