[Fix] propagate subscriptionDependency in CAPApplication templates#108
Merged
Conversation
…plication templates
![hyperspace-insights[bot]](https://avatars.githubusercontent.com/u/2531208?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
The pull request is a focused, well-scoped change that consistently propagates the subscriptionDependency field from serviceInstances into the btp.services section of the CAPApplication template across both the generator (lib/util.js) and all 13 test fixture files. The only substantive issue found is that the value is rendered unquoted, which could silently produce invalid or misinterpreted YAML if the field value contains YAML-special characters — piping through | quote would make it robust.
PR Bot Information
Version: 1.21.1
- File Content Strategy: Full file content
- Event Trigger:
pull_request.opened - Correlation ID:
4e2afe54-d0f2-4cbf-a045-5ba599ed347a - LLM:
anthropic--claude-4.6-sonnet
anirudhprasad-sap
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagate
subscriptionDependencyin CAPApplication TemplatesBug Fix
🐛 Fixed the missing propagation of the
subscriptionDependencyfield fromserviceInstancesto thebtp.servicessection in generatedCAPApplicationHelm templates. When a service instance hadsubscriptionDependencyconfigured, it was previously not included in the rendered output.Changes
lib/util.js: Added a conditional block to emit thesubscriptionDependencyfield in thebtp.servicessection of the CAPApplication template when the field is present on a service instance.package.json: Bumped version from0.16.0to0.16.1.CHANGELOG.md: Added changelog entry for version0.16.1documenting the fix.test/files/expectedChart/templates/cap-operator-cros*.yaml: Updated all expected chart snapshot files to include the newsubscriptionDependencyconditional block.test/files/expectedConfigurableTemplatesChart/templates/cap-operator-cros*.yaml: Updated all configurable template chart snapshots similarly to reflect the fix.PR Bot Information
Version:
1.21.14e2afe54-d0f2-4cbf-a045-5ba599ed347apull_request.openedanthropic--claude-4.6-sonnet