chore: fix build && comment version tags on digests#12
Merged
johanneseschrig merged 4 commits intomainfrom Mar 19, 2026
Merged
Conversation
johanneseschrig
changed the title
johanneseschrig
changed the title
|
✔️ OSS related checks passed successfully RAPID SCAN |
|
✔️ OSS related checks passed successfully RAPID SCAN |
|
✔️ OSS related checks passed successfully RAPID SCAN |
|
✔️ OSS related checks passed successfully RAPID SCAN |
johanneseschrig
changed the title
JenniferStamm
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Adds version comments to digests for better maintainability. See also https://docs.renovatebot.com/modules/manager/github-actions/#digest-pinning-and-updating
The build was failing, since (as far as I was able to trace it) the latest
sapmachine21 (21.0.10.0.1) was resolving to21.0.10+0.1by the setup-java action (+ gets replaced to . and then replaced back), and then cached to21.0.10-0.1at which point the maven enforcer plugin just gave up withThus, patching down to a version 21.0.9, for which no endless semvars seem to exist, so we don't run into setup-java's replacement magic.