test(backups): unit tests for the unit-04 scaffolding - #208
Draft
marceloneppel wants to merge 1 commit into
Draft
Conversation
Each accessor and workload primitive is asserted against its own key, service name and path, so a copy-paste slip between two neighbouring fields fails rather than passing on a shared value. Every service primitive is driven with two distinct names per substrate, because with a single name an implementation that ignored the argument and reached for its own constant would pass unchallenged, and the setters are asserted to leave every sibling key untouched. The cross-scope stanza reader is covered for both precedence and fallback, since a restore that reads the wrong databag silently archives to the wrong repository. Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The unit 04 scaffolding in #207 ships without unit tests, following the code-then-tests split used for the earlier migration units.
Solution
Cover every accessor and workload primitive #207 adds.
Each accessor is asserted against its own key, service name and path, so a copy-paste slip between two neighbouring fields fails rather than passing on a value the fields happen to share. Every service primitive is driven with two distinct names per substrate, because with a single name an implementation that ignored the argument and reached for its own constant would pass unchallenged. Setters are asserted to leave every sibling key untouched, and the cross-scope stanza reader is covered for both precedence and fallback, since a restore that reads the wrong databag silently archives to the wrong repository.
Checklist