Skip to content

Improve TiCS#16283

Merged
tomponline merged 23 commits intocanonical:mainfrom
simondeziel:improve-tics
Aug 26, 2025
Merged

Improve TiCS#16283
tomponline merged 23 commits intocanonical:mainfrom
simondeziel:improve-tics

Conversation

@simondeziel
Copy link
Copy Markdown
Member

@simondeziel simondeziel commented Aug 24, 2025

No description provided.

@simondeziel
client/lxd_events: don't ignore error from r.GetConnectionInfo()
3256445 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
lxd-benchmark: log failure to close CSV
d14605c 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
client/lxd: log failure to close request body
2bf1f7a 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
client/lxd: log failure to get events
7bd5297 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
client/lxd: check error from tcp.ExtractConn()
e70568e 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
client/devlxd: check error from tcp.ExtractConn()
ccb0ef6 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
lxd/instance_sftp: check error from tcp.ExtractConn()
2140e79 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
lxd/response: check error from tcp.ExtractConn()
28c5132 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
shared/ws: check error from tcp.ExtractConn()
efc1978 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
lxd/metrics: replace fmt.Sscanf() by strings.CutPrefix()
8fb658b 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel simondeziel requested a review from Copilot August 24, 2025 20:12

This comment was marked as outdated.

Sign in to view

@simondeziel simondeziel marked this pull request as ready for review August 24, 2025 21:06
kadinsayani
kadinsayani requested changes Aug 25, 2025
View reviewed changes
Comment thread client/lxd.go Outdated
Comment thread lxd/instance/drivers/driver_lxc.go
Comment thread lxd/metrics/metrics.go
Comment thread lxd/response/response.go
Comment thread lxd/migration_connection.go Outdated
Comment thread shared/netutils/network_linux_cgo.go Outdated
@kadinsayani kadinsayani requested a review from Copilot August 25, 2025 20:12
Copilot AI reviewed Aug 25, 2025
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request improves TiCS (likely a code quality tool or static analysis) by addressing various code quality issues and enhancing error handling throughout the LXD codebase.

  • Enhances error handling by properly checking return values from functions like tcp.ExtractConn() and file.Close()
  • Consolidates duplicate IP address scope detection logic into more concise conditional statements
  • Adds test coverage for LXD subcommands and fork subcommands

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test/suites/basic.sh Adds comprehensive test coverage for LXD subcommands and fork subcommands
shared/ws/upgrader.go Improves error handling for TCP connection extraction
shared/netutils/network_linux_cgo.go Consolidates IP address scope detection logic
lxd/response/response.go Enhances error checking for TCP connection extraction
lxd/resources/network.go Consolidates duplicate IP scope detection code
lxd/migration_connection.go Improves TCP connection error handling
lxd/metrics/metrics.go Simplifies CPU device name parsing using strings.CutPrefix
lxd/main_forkfile.go Moves root privilege check after help/version argument handling
lxd/instance_sftp.go Adds proper error checking for TCP connection extraction
lxd/instance/drivers/driver_lxc.go Adds bounds checking for filesystem stats parsing
lxd/api_internal.go Improves error handling for root disk device detection
lxd-benchmark/benchmark/report.go Enhances file closing error handling with proper logging
client/lxd_events.go Adds error handling for connection info retrieval
client/lxd.go Improves error handling for response body closing and event listeners
client/devlxd.go Enhances TCP connection error checking
Comments suppressed due to low confidence (1)

lxd/main_forkfile.go:1

  • The variable listenfd is being overwritten on line 34 without being used, which means the first argument retrieved on line 29 is lost. This appears to be a logic error in argument parsing.
package main

Comment thread lxd/instance/drivers/driver_lxc.go
kadinsayani
kadinsayani previously approved these changes Aug 25, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@kadinsayani kadinsayani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@simondeziel
lxd/instance/drivers/lxc: check array length before access
a69077d 
Point to `man 5 fstab` for a description of each fields.

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
lxd/api_internal: check error returned by `instancetype.GetRootDiskDe…
2cec5ba 
…vice()`

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
shared/network_ip: add GetIPScope() helper
256557f 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
shared/network_ip_test: add tests for GetIPScope()
54871b8 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
lxd/resources/network: use shared.GetIPScope() helper
0bdcdb9 
This fixes a problem with the replaced implementation considering `127:db8::1`
as a link local IP despite being a valid global IPv6.

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
shared/netutils/network_linux_cgo: use shared.GetIPScope() helper
a7f748b 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
lxd-agent/state: use shared.GetIPScope() helper
4868a06 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
lxd/main_forkfile: check for root privs after showing help/version
6c4a140 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
test/suites/basic: call lxd <subcommand> --help
b3fe666 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
client/devlxd: avoid deprecated conn.UnderlyingConn()
b67eefb 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
client/lxd: avoid deprecated conn.UnderlyingConn()
72906bb 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
lxd/migration_connection: avoid deprecated conn.UnderlyingConn()
a48a7c9 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
shared/ws/upgrader: avoid deprecated conn.UnderlyingConn()
3a7bdc6 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
tomponline
tomponline approved these changes Aug 26, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@tomponline tomponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@tomponline tomponline merged commit 00a0238 into canonical:main Aug 26, 2025
31 checks passed
@simondeziel simondeziel deleted the improve-tics branch August 26, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kadinsayani kadinsayani kadinsayani left review comments

Copilot code review Copilot Copilot left review comments

@tomponline tomponline tomponline approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@simondeziel @tomponline @kadinsayani