feat: show valid/total relations count in status after haproxy-route reconciliation#559
Open
Copilot wants to merge 4 commits into
Open
feat: show valid/total relations count in status after haproxy-route reconciliation#559Copilot wants to merge 4 commits into
Copilot wants to merge 4 commits into
Conversation
…reconciliation After reconciling haproxy-route and haproxy-route-tcp configurations, the unit status now displays how many relations are valid vs total, e.g. "2/3 haproxy-route, 1/1 haproxy-route-tcp". Closes #558
Copilot
AI
changed the title
[WIP] Show valid relations count after reconciliation for haproxy route
feat: show valid/total relations count in status after haproxy-route reconciliation
Jun 16, 2026
Show a unified "x/y valid relations" message instead of separate counts per interface type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
After haproxy-route reconciliation, displays a unified count of valid vs total relations (combining both haproxy-route and haproxy-route-tcp) in the unit's
ActiveStatusmessage. Example output:When no relations exist, the status message is empty.
Changes:
_configure_haproxy_routenow returns a status message string_get_haproxy_route_status_messagehelper that computes combinedvalid/totalacross both haproxy-route and haproxy-route-tcp usingrelation_ids_with_invalid_dataandrelation_ids_with_invalid_data_tcp_reconcilepasses the message toActiveStatusWhy we need it
Operators currently have no visibility into which haproxy-route/haproxy-route-tcp relations are valid after config reconciliation. This makes debugging misconfigured requirers harder than necessary.
Test plan
test_spoe_auth,test_two_spoe_auth) to assert the new status message formatReview focus
"x/y valid relations"— single combined count for both interfacesChecklist
docs/changelog.mdwith user-relevant changesdocs/release-notes/artifacts. If no change artifact is necessary, I tagged the PR with the labelno-release-note.(e.g., in
.github/workflows/integration_tests.yaml, ensure themoduleslist is correct)terraform fmtpasses andtflintreports no errors