Feat/eng 1753

src/agent/core/domain/agent-events/types.ts

@@ -18,6 +18,7 @@ export const AGENT_EVENT_NAMES = [
  */
 export const SESSION_EVENT_NAMES = [
   'llmservice:chunk',
+  'llmservice:compressionQuality',
   'llmservice:contextCompressed',
   'llmservice:contextOverflow',
   'llmservice:contextPruned',
@@ -230,6 +231,20 @@ export interface AgentEventMap {
     type: 'reasoning' | 'text'
   }
 
+  /**
+   * Emitted after the full compression pipeline completes, reporting quality dimensions
+   * of the final compressed output (Pattern 4). Forwarded from SessionEventMap with sessionId.
+   */
+  'llmservice:compressionQuality': {
+    dimensions: {
+      factualCompleteness: number
+      toolContextPreservation: number
+      userIntentClarity: number
+    }
+    overallScore: number
+    sessionId: string
+  }
+
   /**
    * Emitted when conversation context is compressed via summarization.
    * @property {number} compressedTokens - Token count after compression
@@ -592,6 +607,21 @@ export interface SessionEventMap {
     type: 'reasoning' | 'text'
   }
 
+  /**
+   * Emitted after the full compression pipeline completes, reporting quality dimensions
+   * of the final compressed output (Pattern 4).
+   * @property {object} dimensions - Per-dimension quality scores (0-1)
+   * @property {number} overallScore - Weighted overall quality score (0-1)
+   */
+  'llmservice:compressionQuality': {
+    dimensions: {
+      factualCompleteness: number
+      toolContextPreservation: number
+      userIntentClarity: number
+    }
+    overallScore: number
+  }
+
   /**
    * Emitted when conversation context is compressed via summarization.
    * @property {number} compressedTokens - Token count after compression

src/agent/core/interfaces/cipher-services.ts

@@ -69,6 +69,7 @@ export interface CipherAgentServices {
  * - LLMService: LLM client with isolated context manager
  */
 export interface SessionServices {
+  cleanup?: () => void
   llmService: ILLMService
   sessionEventBus: SessionEventBus
 }

src/agent/core/interfaces/i-sandbox-service.ts

@@ -1,3 +1,4 @@
+import type { SessionInsightsTracker } from '../../../server/infra/context-tree/session-insights-tracker.js'
 import type { ISearchKnowledgeService } from '../../infra/sandbox/tools-sdk.js'
 import type { SessionManager } from '../../infra/session/session-manager.js'
 import type { EnvironmentContext } from '../domain/environment/types.js'
@@ -74,6 +75,14 @@ export interface ISandboxService {
    */
   setFileSystem?(fileSystem: IFileSystem): void
 
+  /**
+   * Set the session insights tracker for performance correlation.
+   * When set, ToolsSDK.searchKnowledge() records surfaced paths per session.
+   *
+   * @param tracker - Session insights tracker instance
+   */
+  setInsightsTracker?(tracker: SessionInsightsTracker): void
+
   /**
    * Set a variable in a session's sandbox.
    * If the sandbox doesn't exist yet, the variable is buffered and injected

src/agent/infra/agent/cipher-agent.ts

@@ -688,6 +688,15 @@ export class CipherAgent extends BaseAgent implements ICipherAgent {
     }
   }
 
+  /**
+   * Set the session insights tracker for performance-memory correlation.
+   * Forwarded to sandboxService so ToolsSDK.searchKnowledge() records surfaced paths.
+   */
+  public setInsightsTracker(tracker: import('../../../server/infra/context-tree/session-insights-tracker.js').SessionInsightsTracker): void {
+    this.ensureStarted()
+    this.services!.sandboxService.setInsightsTracker?.(tracker)
+  }
+
   /**
    * Set a variable in the agent's default session sandbox.
    */

src/agent/infra/agent/service-initializer.ts

@@ -24,9 +24,11 @@ import { AgentEventBus, SessionEventBus } from '../events/event-emitter.js'
 import { FileSystemService } from '../file-system/file-system-service.js'
 import { AgentLLMService } from '../llm/agent-llm-service.js'
 import { CompactionService } from '../llm/context/compaction/compaction-service.js'
+import { CompressionQualityEvaluator } from '../llm/context/compression/compression-quality-evaluator.js'
 import { EscalatedCompressionStrategy } from '../llm/context/compression/escalated-compression.js'
 import { MiddleRemovalStrategy } from '../llm/context/compression/middle-removal.js'
 import { OldestRemovalStrategy } from '../llm/context/compression/oldest-removal.js'
+import { SessionProgressTracker } from '../llm/context/session-progress-tracker.js'
 import {
   LoggingContentGenerator,
   RetryableContentGenerator,
@@ -44,6 +46,8 @@ import { GranularHistoryStorage } from '../storage/granular-history-storage.js'
 import { MessageStorageService } from '../storage/message-storage-service.js'
 import { ContextTreeStructureContributor } from '../system-prompt/contributors/context-tree-structure-contributor.js'
 import { MapSelectionContributor } from '../system-prompt/contributors/map-selection-contributor.js'
+import { PerformanceTrendContributor } from '../system-prompt/contributors/performance-trend-contributor.js'
+import { ProgressTrajectoryContributor } from '../system-prompt/contributors/progress-trajectory-contributor.js'
 import { SystemPromptManager } from '../system-prompt/system-prompt-manager.js'
 import { CoreToolScheduler } from '../tools/core-tool-scheduler.js'
 import { DEFAULT_POLICY_RULES } from '../tools/default-policy-rules.js'
@@ -208,6 +212,13 @@ export async function createCipherAgentServices(
   const mapSelectionContributor = new MapSelectionContributor('mapSelection', 16)
   systemPromptManager.registerContributor(mapSelectionContributor)
 
+  // Register performance trend contributor for curate/query commands
+  // Priority 17 — after map selection, before memories
+  const performanceTrendContributor = new PerformanceTrendContributor('performanceTrend', 17, {
+    workingDirectory,
+  })
+  systemPromptManager.registerContributor(performanceTrendContributor)
+
   // 7. Abstract generation queue (generator injected later via rebindCurateTools)
   const abstractQueue = new AbstractGenerationQueue(workingDirectory)
 
@@ -310,6 +321,10 @@ export function createSessionServices(
   // 1. Create session-specific event bus
   const sessionEventBus = new SessionEventBus()
 
+  // 1b. Create session progress tracker (Pattern 1: Progress Trajectory)
+  const progressTracker = new SessionProgressTracker(sessionEventBus)
+  progressTracker.attach()
+
   // 2. Create session-scoped logger
   const sessionLogger = new EventBasedLogger(sharedServices.agentEventBus, 'LLMService', sessionId)
 
@@ -350,6 +365,12 @@ export function createSessionServices(
       model: llmConfig.model ?? 'gemini-3-flash-preview',
     })
 
+    // Per-session progress contributor (Pattern 1)
+    const progressContributor = new ProgressTrajectoryContributor('progress', 25, progressTracker)
+
+    // Pattern 4: compression quality evaluator (final-output evaluation after full chain)
+    const compressionQualityEvaluator = new CompressionQualityEvaluator({warningThreshold: 0.5})
+
     return new AgentLLMService(
       sessionId,
       generator,
@@ -364,6 +385,7 @@ export function createSessionServices(
       },
       {
         compactionService: sharedServices.compactionService,
+        compressionQualityEvaluator,
         compressionStrategies: [
           escalatedStrategy,
           new MiddleRemovalStrategy({preserveEnd: 5, preserveStart: 4}),
@@ -372,7 +394,9 @@ export function createSessionServices(
         historyStorage: sharedServices.historyStorage,
         logger: sessionLogger,
         memoryManager: sharedServices.memoryManager,
+        progressTracker,
         sandboxService: sharedServices.sandboxService,
+        sessionContributors: [progressContributor],
         sessionEventBus,
         systemPromptManager: sharedServices.systemPromptManager,
         toolManager: sharedServices.toolManager,
@@ -401,6 +425,9 @@ export function createSessionServices(
   // to ensure proper cleanup when sessions are disposed
 
   return {
+    cleanup() {
+      progressTracker.detach()
+    },
     llmService,
     sessionEventBus,
   }

src/agent/infra/llm/agent-llm-service.ts

@@ -2,6 +2,7 @@ import type {MessageParam} from '@anthropic-ai/sdk/resources/messages'
 import type {Content} from '@google/genai'
 import type {ChatCompletionMessageParam} from 'openai/resources/chat/completions'
 
+import type {SystemPromptContributor} from '../../core/domain/system-prompt/types.js'
 import type {ToolExecutionResult} from '../../core/domain/tools/tool-error.js'
 import type {ToolSet} from '../../core/domain/tools/types.js'
 import type {ExecutionContext} from '../../core/interfaces/i-cipher-agent.js'
@@ -22,7 +23,9 @@ import type {MemoryManager} from '../memory/memory-manager.js'
 import type {SystemPromptManager} from '../system-prompt/system-prompt-manager.js'
 import type {ToolManager} from '../tools/tool-manager.js'
 import type {CompactionService} from './context/compaction/compaction-service.js'
+import type {CompressionQualityEvaluator} from './context/compression/compression-quality-evaluator.js'
 import type {ICompressionStrategy} from './context/compression/types.js'
+import type {SessionProgressTracker} from './context/session-progress-tracker.js'
 
 import {getErrorMessage} from '../../../server/utils/error-helpers.js'
 import {AgentStateMachine} from '../../core/domain/agent/agent-state-machine.js'
@@ -173,10 +176,14 @@ export class AgentLLMService implements ILLMService {
   private readonly metadataHandler: ToolMetadataHandler
   private readonly mutex = new AsyncMutex()
   private readonly outputProcessor: ToolOutputProcessor
+  /** Optional progress tracker for recording iteration completions (Pattern 1). */
+  private readonly progressTracker?: SessionProgressTracker
   private readonly providerId: string
   private readonly providerType: 'claude' | 'gemini' | 'openai'
-  /** Optional sandbox service for rolling checkpoint variable injection (Pattern 1) */
+  /** Optional sandbox service for rolling checkpoint variable injection */
   private readonly sandboxService?: ISandboxService
+  /** Per-session system prompt contributors (appended after shared SystemPromptManager output). */
+  private readonly sessionContributors: SystemPromptContributor[]
   private readonly sessionEventBus: SessionEventBus
   private readonly sessionId: string
   private readonly systemPromptManager: SystemPromptManager
@@ -215,13 +222,19 @@ export class AgentLLMService implements ILLMService {
     config: AgentLLMServiceConfig,
     options: {
       compactionService?: CompactionService
+      /** Optional quality evaluator for measuring compression output (Pattern 4). */
+      compressionQualityEvaluator?: CompressionQualityEvaluator
       /** Optional compression strategies for context overflow management */
       compressionStrategies?: ICompressionStrategy[]
       historyStorage?: IHistoryStorage
       logger?: ILogger
       memoryManager?: MemoryManager
+      /** Optional progress tracker for recording iteration completions (Pattern 1). */
+      progressTracker?: SessionProgressTracker
       /** Optional sandbox service for rolling checkpoint variable injection */
       sandboxService?: ISandboxService
+      /** Per-session system prompt contributors (appended after shared prompt). */
+      sessionContributors?: SystemPromptContributor[]
       sessionEventBus: SessionEventBus
       systemPromptManager: SystemPromptManager
       toolManager: ToolManager
@@ -230,7 +243,9 @@ export class AgentLLMService implements ILLMService {
     this.sessionId = sessionId
     this.generator = generator
     this.compactionService = options.compactionService
+    this.progressTracker = options.progressTracker
     this.sandboxService = options.sandboxService
+    this.sessionContributors = options.sessionContributors ?? []
     this.toolManager = options.toolManager
     this.systemPromptManager = options.systemPromptManager
     this.memoryManager = options.memoryManager
@@ -281,10 +296,13 @@ export class AgentLLMService implements ILLMService {
 
     // Initialize context manager with optional history storage
     this.contextManager = new ContextManager({
+      compressionQualityEvaluator: options.compressionQualityEvaluator,
       compressionStrategies: options.compressionStrategies,
       formatter: this.formatter,
       historyStorage: options.historyStorage,
+      logger: this.logger,
       maxInputTokens: this.config.maxInputTokens,
+      sessionEventBus: options.sessionEventBus,
       sessionId,
       tokenizer: this.tokenizer,
     })
@@ -370,9 +388,13 @@ export class AgentLLMService implements ILLMService {
           tools: toolSet,
         })
 
+        // Record completed iteration before result check so one-turn tasks are counted
+        this.progressTracker?.recordIteration()
+
         if (result !== null) {
           // Task complete - no tool calls
           stateMachine.complete()
+
           return result
         }
 
@@ -921,6 +943,19 @@ export class AgentLLMService implements ILLMService {
       systemPrompt = systemPrompt + '\n\n' + reflectionPrompt
     }
 
+    // Append per-session contributor content (never cached — changes every iteration)
+    for (const contributor of this.sessionContributors) {
+      // eslint-disable-next-line no-await-in-loop -- Sequential to maintain deterministic prompt ordering
+      const content = await contributor.getContent({
+        availableMarkers,
+        availableTools,
+        commandType: executionContext?.commandType,
+      })
+      if (content) {
+        systemPrompt = systemPrompt + '\n\n' + content
+      }
+    }
+
     // Verbose debug: Show complete system prompt
     if (this.config.verbose) {
       this.logger.debug('System prompt details', {