Enhance xml import utility#1082
Merged
birm merged 7 commits intocamicroscope:developfrom Feb 20, 2025
Merged
Conversation
…dent annotations, and bounding boxes
Contributor
Author
|
Hey @birm, Also I feel like the GitHub Actions axe tests in are failing due to a ChromeDriver version mismatch. axe-cli is using Chrome 133 because GitHub Actions is installing the latest Chrome by default, but the workflow in .github/workflows/axe-a11y-check.yml is manually installing ChromeDriver 125, causing the failure. Just thought should let you know this is happening. Thanks. |
Member
|
Hi @chandrikarj -- don't worry about the axe check at this point. |
Contributor
Author
|
Thanks, @birm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhancements to XML import: Color parsing, polyline handling, independent annotations, and bounding boxes
Summary
-Color Representation Fix:
The line color in the XML annotation is now correctly parsed from a decimal representation to a hexadecimal format.
-Handling Polyline vs. Polygon:
The XML import utility now differentiates between Polyline and polygons.
Now, if the region type is Polyline, it is correctly mapped to a LineString, while Polygon regions remain unchanged.
-Independent Annotation Groups:
Each XML annotation group is now processed as a separate annotation object.
-Bounding Box Implementation:
The bounding box is calculated as the smallest enclosing rectangle around the annotation, using the min/max X and Y coordinates.
The videos demonstrating the changes are below :
Before:
Screen.Recording.2025-02-12.at.11.46.13.PM.mov
After:
Screen.Recording.2025-02-12.at.11.46.57.PM.mov
Motivation
This PR improves the XML import utility by addressing multiple issues outlined in Issue #1081.