feat: reject NIP-70 protected events#644
Open
Anshumancanrock wants to merge 2 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 58e3e46 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Anshumancanrock
force-pushed
the
nip70-reject-protected-events
branch
from
4086a19 to
35f12a9
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds enforcement for NIP-70 “protected events” at the relay handler level by rejecting events tagged with ["-"] and rejecting kind-6 reposts whose embedded event includes a protected tag, with accompanying unit tests and a changeset.
Changes:
- Add
isProtectedEventBlocked()logic inEventMessageHandlerand invoke it aftercanAcceptEvent. - Reject kind-6 reposts that embed protected events in their JSON
content. - Add unit tests for direct protected tags, repost-embedded protected tags, and malformed/edge-case content; include a changeset entry.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/handlers/event-message-handler.ts |
Adds protected-event/repost-embed rejection logic and wires it into message handling. |
test/unit/handlers/event-message-handler.spec.ts |
Adds unit tests covering protected-tag and repost-embedding behavior plus edge cases. |
.changeset/nip70-reject-protected-events.md |
Declares a minor release changeset for the new NIP-70 rejection behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
18
to
26
| isDirectMessageEvent, | ||
| isEventIdValid, | ||
| isEventKindOrRangeMatch, | ||
| isEventSignatureValid, | ||
| isExpiredEvent, | ||
| isFileMessageEvent, | ||
| isProtectedEvent, | ||
| isRequestToVanishEvent, | ||
| isSealEvent, |
Comment on lines
+243
to
+246
| if ( | ||
| Array.isArray(embedded?.tags) && | ||
| embedded.tags.some((tag: string[]) => Array.isArray(tag) && tag[0] === EventTags.Protected) | ||
| ) { |
Comment on lines
+249
to
+250
| } catch (_e) { | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds rejection logic for NIP-70 protected events in
EventMessageHandler.["-"]tag get rejected withauth-required: this event may only be published by its author(same message the spec uses in its example).contentare also rejected.canAcceptEventso content-length limits kick in before weJSON.parserepost content.Related Issue
Part of NIP-70 support. Follows #643 which added the detection utility.
Motivation and Context
NIP-70 says relays MUST reject events with
["-"]by default. Without this, those events just get stored and spread like any other event, which breaks the whole point of the tag. The repost check also covers the case where someone sticks a protected event inside a kind-6 repost body to get around the outer tag check.How Has This Been Tested?
10 unit tests added to
event-message-handler.spec.tscovering:["-"](should pass through)auth-requiredbefore the embed checktagsfield in parsed JSON)Screenshots (if appropriate):
N/A
Types of changes
Checklist: