feat: wot core service#642
Conversation
🦋 Changeset detectedLatest commit: 47b2fc6 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
coverage: 66.831% (-0.2%) from 66.995% — saniddhyaDubey:feat/wot#2-service into cameri:main |
| } | ||
| settled = true | ||
| clearTimeout(timer) | ||
| try { ws.close() } catch { /* ignore */ } |
There was a problem hiding this comment.
does this clean up the events listening on open, message, error, close?
|
|
||
| ws.on('error', (err) => { | ||
| logger.warn('wot-service: WebSocket error for %s: %o', relayUrl, err) | ||
| finish() |
There was a problem hiding this comment.
should we pass the error and end with a rejection instead of resolve()?
| relayUrls.map((url) => fetchEvents(url, filter, timeoutMs)) | ||
| ) | ||
|
|
||
| const seen = new Set<string>() |
There was a problem hiding this comment.
this dedup in memory is unbounded, so for a popular user following many other usrs this can cause Nostream to get OOM-killed
In these scenarios, we are better off using a bloom filter, and use streams to process the information so the amount of memory used is manageable
| */ | ||
| public constructor(private readonly fetcher: RelayFetcher = fetchFromRelays) {} | ||
|
|
||
| public async buildGraph(settings: WoTSettings): Promise<void> { |
There was a problem hiding this comment.
the amount of memory used by this function will also be quite significant, would it be a better choice to try and build the graph using PostgreSQL and use queries instead?
3 participants
Description
Introduces WotService - the core Web of Trust graph logic. Builds a 2-hop trust graph rooted at the relay owner's pubkey by fetching kind-3 follow lists from configured seed relays.
Also patches the wot: config block (#623) with the missing seedRelays field, and updates the settings unit tests accordingly.
Related Issue
Closes (#626).
How Has This Been Tested?
14 new unit tests in
test/unit/services/wot-service.spec.tscover:seedPubkeyalways trusted regardless of follower countminimumFollowersthreshold : pubkeys above pass, pubkeys below are rejectedbuildGraph()calls are no-opsbuildingflag cleared correctly even when the build throwsptags and pubkeys shorter than 64 chars ignoredreset()clears all state and allows a fresh buildScreenshots (if appropriate):
Types of changes
Checklist: