fix(alta_open): handle new-format webhook fields (status/enrollType)#11
Merged
Conversation
- Add pythonpath = ["."] to pyproject.toml so project modules are importable - Fix 4 test files using from tests.neon_mocker to from neon_mocker to match pytest rootdir import behavior - Skip TestClassFeedbackAutomation (google-auth not installed) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
New-format webhooks use 'status' and 'enrollType' instead of 'transactionStatus' and 'enrollmentType'. Branch on the legacy flag to read the correct fields, and remove xfail from the tests that now pass. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… logs
Captured 306 real createMembership events (2026-06-02..07-02) and
corrected the characterization fixtures to match:
- New-format events arrive with customParameters null today (the new
webhook was activated without its legacy/webhook_name params), and
will carry legacy:"false" once those are added. Both take the
handler's non-legacy branch, so the join tests now run against both
variants.
- Use the real legacy webhook_name (NewMembershipLegacy) and a
realistic, PII-scrubbed flat payload (rich membership body + payments
with card details) instead of the minimal inferred shape.
- Confirmed real enum values: status in {SUCCEEDED, FAILED},
enrollType in {JOIN, RENEW}.
- Drop the stale ASSUMED-SHAPE comment and dead NEW_JOIN_XFAIL marker.
- gitignore captured *_logs.json (member PII).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
camdroid
added a commit
that referenced
this pull request
Jul 13, 2026
* test(alta_open): characterize new-format webhook handling (xfail join gaps) (#10) * fix(alta_open): handle new-format webhook fields (status/enrollType) (#11) * test(alta_open): characterize new-format webhook handling (xfail join gaps) * fix(tests): get test suite running locally (no behavior changes) - Add pythonpath = ["."] to pyproject.toml so project modules are importable - Fix 4 test files using from tests.neon_mocker to from neon_mocker to match pytest rootdir import behavior - Skip TestClassFeedbackAutomation (google-auth not installed) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(alta_open): handle new-format webhook fields (status/enrollType) New-format webhooks use 'status' and 'enrollType' instead of 'transactionStatus' and 'enrollmentType'. Branch on the legacy flag to read the correct fields, and remove xfail from the tests that now pass. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * test(alta_open): align new-format createMembership fixtures with real logs Captured 306 real createMembership events (2026-06-02..07-02) and corrected the characterization fixtures to match: - New-format events arrive with customParameters null today (the new webhook was activated without its legacy/webhook_name params), and will carry legacy:"false" once those are added. Both take the handler's non-legacy branch, so the join tests now run against both variants. - Use the real legacy webhook_name (NewMembershipLegacy) and a realistic, PII-scrubbed flat payload (rich membership body + payments with card details) instead of the minimal inferred shape. - Confirmed real enum values: status in {SUCCEEDED, FAILED}, enrollType in {JOIN, RENEW}. - Drop the stale ASSUMED-SHAPE comment and dead NEW_JOIN_XFAIL marker. - gitignore captured *_logs.json (member PII). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> * Remove unnecessary line from gitignore --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
alta_open_lambda/lambda_function.py: The webhook handler now reads the correct fields depending on payload format. New-format webhooks sendstatusandenrollType, whereas legacy webhooks sendtransactionStatusandenrollmentType. The handler branches on the legacy flag to pull the right keys.tests/test_alta_open_lambda.py: Added characterization tests for the webhook handler covering both formats, and removed thexfailmarkers from the join-gap cases that now pass with the fix.test_*.pyfiles, plus apyproject.tomladdition). No behavior changes to production code beyond the lambda fix above.Why
New-format Alta webhooks were being processed with legacy field names, so
status/enrollTypewere read as missing. Branching on the format flag resolves the join gaps the earlier characterization tests documented asxfail.Reviewer notes
xfailed tests are now expected to pass — confirms the fix end-to-end.