add coupled unsteady problem and solver#161
Closed
JonahJ27 wants to merge 3 commits intocamUrban:class_structurefrom
Closed
add coupled unsteady problem and solver#161JonahJ27 wants to merge 3 commits intocamUrban:class_structurefrom
JonahJ27 wants to merge 3 commits intocamUrban:class_structurefrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## class_structure #161 +/- ##
===================================================
+ Coverage 91.70% 91.73% +0.02%
===================================================
Files 34 35 +1
Lines 6752 6953 +201
===================================================
+ Hits 6192 6378 +186
- Misses 560 575 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
Thanks for taking the new class structure for a test drive. Good to see the foundation works for the aeroelastic use case. A couple of things before we move forward:
Nice work validating the design. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Provide a concise description of the changes in this pull request. Appropriate titles for PRs use sentence-case and no trailing period. Also, add applicable labels and assign the PR to yourself. If using the
bugorfeaturelabel, prefix your title with [BUG] or [FEATURE]. If a first-time contributor, welcome! If you'd like, feel free to add yourself to the end of the list of contributors in the README, following one of the styles shown.Motivation
Explain why you are making these changes and what problem they solve.
Relevant Issues
Link any related issues using GitHub's syntax. For bugs, write, "Fixes #." For features, "Closes #." If there are no related issues, write "None."
Changes
List the changes you made in bullet points.
Dependency Updates
List any new dependencies (including dev dependencies) added in this PR. Also list any updates to required dependency versions. If no new dependencies have been added or version requirements changed, write "None."
Change Magnitude
Identify the option that best describes the impact of your change, then delete the other two lines and this sentence.
Major: Large change that adds significant new functionality, changes existing behavior, or may affect many parts of the codebase.
Moderate: Medium-sized change that adds or modifies a feature without large-scale impact.
Minor: Small change such as a bug fix, small enhancement, or documentation update.
Checklist (check each item when completed or not applicable)
mainand is up to date with the upstreammainbranch.--in-place --black). See the style guide for type hints and docstrings for more details.pterasoftwarepackage use type hints. See the style guide for type hints and docstrings for more details.testspackage.testspackage.black,codespell, andisortGitHub actions.mypyGitHub action.testsGitHub actions.