Skip to content

fix(reminder-modal): make the relative/absolute tab toggle switch fields #2080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JunwonYoon wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(reminder-modal): make the relative/absolute tab toggle switch fields #2080

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions styles/reminder-modal.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,22 @@ body.is-mobile .tasknotes-plugin .reminder-modal__action-btn svg {
display: none;
}

/* The relative/absolute tab toggle (ReminderModal.updateFormVisibility) switches
fields by adding the generic .tn-static-display-{none,block} utility classes.
Those are single-class (0-1-0) and lose to the scoped base rules above
(.tasknotes-plugin .{relative,absolute}-fields, 0-2-0), so without these
overrides the toggle has no effect and the Absolute tab appears to do nothing.
Scope the toggle to these containers so it wins, keeping flex layout when shown. */
.tasknotes-plugin .relative-fields.tn-static-display-none-6b99de8b,
.tasknotes-plugin .absolute-fields.tn-static-display-none-6b99de8b {
display: none;
}

.tasknotes-plugin .relative-fields.tn-static-display-block-2a1b75c9,
.tasknotes-plugin .absolute-fields.tn-static-display-block-2a1b75c9 {
display: flex;
}

/* Form controls - Match Task Modal Details Section */
.tasknotes-plugin .reminder-modal__form .setting-item {
padding: var(--size-4-2) 0;
Expand Down