Fix Google Calendar archive cleanup reliability#1706
Open
martin-forge wants to merge 3 commits intocallumalpass:mainfrom
Open
Fix Google Calendar archive cleanup reliability#1706martin-forge wants to merge 3 commits intocallumalpass:mainfrom
martin-forge wants to merge 3 commits intocallumalpass:mainfrom
Conversation
fea5663 to
2619966
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1695.
What this changes
toggleArchive()instead of firing it and forgetting itdeleteTaskFromCalendar()return success/failure and only cleargoogleCalendarEventIdafter a confirmed delete or a404/410Why
The previous flow could archive a task locally while the Google event remained behind, and on some failure paths the local
googleCalendarEventIdcould be cleared anyway. That leaves an orphaned event with no local pointer for retry.This PR makes the archive flow retry-safe: local archive can still succeed, but the event ID is preserved until Google deletion actually succeeds, and the auto-archive queue keeps retrying cleanup while the link remains.
Tests
npx jest tests/unit/services/TaskService.test.ts --runInBandnpx jest tests/unit/issues/issue-google-calendar-archive-reliability.test.ts --runInBandI also validated the patch on a clean upstream copy after generating the release notes bundle required for typecheck/build in this repo.