Added projectId, project, and projects templates for filenames.#1664
Open
bendavis987 wants to merge 1 commit intocallumalpass:mainfrom
Open
Added projectId, project, and projects templates for filenames.#1664bendavis987 wants to merge 1 commit intocallumalpass:mainfrom
bendavis987 wants to merge 1 commit intocallumalpass:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the discussion on #1178, I have made changes that are less intrusive.
In the time that's passed, the code around these file name formats has gotten a lot clearer, so I've only added these as custom templates (filename only).
The projectId template essentially only shortens the project name to four characters in caps, and the filename exists check just increments this.
This seems to be the best option without combining the generateCustomFilename and generateUniqueFilename functions. This naming depends on the taskdata in custom and the vault access for the increment. Since this is handled by the custom naming, it also allows different combinations with this projectId. Like my new setting below.
Would you be interested in unifying these replacements? IE: folderTemplateProcessor is essentially duplicated, but not as clear. I'd be willing to look into this.