For discussion: Mount API that takes a single object #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 2, 2017 14:39
…ad of 3 parameters
Owner
|
This is a good idea. I guess that because the second argument is already an object it wouldn't be possible to just detect whether someone is using arguments or an object :( |
Collaborator
Author
|
@callumacrae Do you have any issue with me merging in this PR--- it will break the existing API, but in the end I think it's for the best |
Collaborator
Author
|
Also, have you seen this discussion re: unit testing in Vue: https://forum.vuejs.org/t/is-anything-being-done-in-core-vue-to-make-unit-testing-easier/7431/9 ? Are you interested in participating? |
Owner
|
Yep, I like the API changes made in this PR. Looks like it needs a bit of cleaning up and documenting, but happy for you to merge :) Hadn't seen that, will sign up and reply. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EXAMPLE to be discussed-- mount API that takes 1 options object instead of 3 parameters