fix(network-activity-plugin): filter internal initiator frames#298
Open
V3RON wants to merge 1 commit into
Open
fix(network-activity-plugin): filter internal initiator frames#298V3RON wants to merge 1 commit into
V3RON wants to merge 1 commit into
Conversation
Avoid sending Hermes internal bytecode pseudo-files to Metro symbolication. Preserve source-mapped request initiator details for valid Metro bundle frames.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this?
This PR fixes Network Activity initiator symbolication for Hermes stacks that include internal bytecode frames. Mixed stacks could previously send pseudo-files like
address at InternalBytecode.jsto Metro, which made Metro try to read them as project files during code-frame generation.Fixes #294.
How does it work?
The initiator symbolication helper now sends only Metro-symbolicatable generated frames to
/symbolicate, currently the frames backed by HTTP bundle URLs. It keeps track of each submitted frame's original stack index, then merges the symbolicated result back into the original initiator stack so internal Hermes frames remain available as generated context without being treated as source files.Why is this useful?
Network Activity keeps source-mapped request initiator details for real app frames while avoiding noisy Metro file-read failures for Hermes internals. The fix is narrow to symbolication payload construction, so existing initiator display behavior stays intact for valid Metro bundle frames.