Skip to content

fix: prevent overflow crash on older android versions #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ryan-karn wants to merge 2 commits into
base: main
Choose a base branch
from
+15 −0
Open

fix: prevent overflow crash on older android versions #31

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6cf6df
fix: prevent overflow crash on older android versions
Apr 14, 2026
fc5f1cf
chore: missed space in comment form prev commit
Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions ...native-sandbox/android/src/main/java/io/callstack/rnsandbox/SandboxReactNativeDelegate.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,6 +382,21 @@ class SandboxReactNativeDelegate(
override fun getFilesDir(): java.io.File = sandboxFilesDir

override fun getApplicationContext(): Context = this

/**
* On Android 12 and below, Context.registerComponentCallbacks() delegates to
* getApplicationContext().registerComponentCallbacks(). Since getApplicationContext()
* returns `this` in SandboxContextWrapper, that causes infinite recursion and a
* StackOverflowError. Android 13+ fixed this in ContextWrapper by delegating to mBase
* directly. We mirror that fix here to support older platforms.
*/
override fun registerComponentCallbacks(callback: android.content.ComponentCallbacks) {
baseContext.applicationContext.registerComponentCallbacks(callback)
}

override fun unregisterComponentCallbacks(callback: android.content.ComponentCallbacks) {
baseContext.applicationContext.unregisterComponentCallbacks(callback)
}
}

private class FilteredReactPackage(
Expand Down