chore: address backlog nits and add missing test coverage#26
Open
chore: address backlog nits and add missing test coverage#26
Conversation
Nits: - Remove unused #include <iostream> and #include <memory> (N-2) - Remove redundant -std=c++17 compile option (N-3) - Restrict SandboxReactNativeView field visibility to internal (N-6) - Downgrade FilteredReactPackage substitution miss log to Log.d (N-7) - Pin ktlint to 1.8.0 instead of latest (N-8) - Add missing trailing newlines to cxx headers (N-10) - Add explanatory comment for cmakeListsPath: null (N-11) Tests: - allowedOrigins overwrite on re-registration with same origin - unregisterDelegate with unknown delegate is a no-op - findAll with non-existent origin returns empty - reset() releases shared_ptr references
Clear __FUSEBOX_HAS_FULL_CONSOLE_SUPPORT__ via shared JSI utility so LogBoxData.addLog() never creates the undismissable "Open debugger to view warnings." toast inside sandbox views. - Add cxx/SandboxLogBox.h with disableFuseboxLogBoxToast() - Android: clear pre-bundle in BindingsInstaller + post-bundle safety net - iOS: clear post-bundle in buffered executor (Fusebox re-sets flag after didInitializeRuntime:, so pre-bundle clearing is a no-op) - Remove LogBox from TurboModule whitelist Closes #12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nits:
#include <iostream>and#include <memory>-std=c++17compile optionSandboxReactNativeViewfield visibility tointernalFilteredReactPackagesubstitution miss log toLog.dktlintto 1.8.0 instead of latestcxxheaderscmakeListsPath: nullTests:
allowedOriginsoverwrite on re-registration with same originunregisterDelegatewith unknown delegate is a no-opfindAllwith non-existent origin returns emptyreset()releasesshared_ptrreferences