Conversation
c4a9636 to
4bc1249
Compare
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Bug: Missing Peer Dependency Breaks CMake Find Package
Missing weak-node-api peer dependency. The package now generates CMakeLists.txt files with find_package(weak-node-api REQUIRED CONFIG) according to the CHANGELOG (commit 60fae96), but doesn't declare weak-node-api as a peer dependency. Users who generate CMake configurations with this tool will encounter build failures when CMake cannot find the weak-node-api package.
packages/gyp-to-cmake/package.json#L26-L30
react-native-node-api/packages/gyp-to-cmake/package.json
Lines 26 to 30 in 4bc1249
| "@react-native-node-api/cli-utils": "0.1.1", | ||
| "cmake-file-api": "0.1.0", | ||
| "react-native-node-api": "0.6.2", | ||
| "react-native-node-api": "0.7.0", |
There was a problem hiding this comment.
Bug: Missing Peer Dependency Causes CMake Configuration Failures
Missing weak-node-api peer dependency. The package now uses find_package(weak-node-api REQUIRED CONFIG) according to the CHANGELOG (commit 60fae96), but doesn't declare weak-node-api as a peer dependency. Since react-native-node-api only has weak-node-api as a peerDependency (not a regular dependency), users of cmake-rn won't have weak-node-api installed automatically, causing CMake configuration failures when it tries to find the package.
4bc1249 to
144f262
Compare
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
cmake-rn@0.6.0
Minor Changes
find_packageinstead ofincludeto locate "weak-node-api"Patch Changes
gyp-to-cmake@0.5.0
Minor Changes
find_packageinstead ofincludeto locate "weak-node-api"react-native-node-api@0.7.0
Minor Changes
find_packageinstead ofincludeto locate "weak-node-api"Patch Changes
ferric-cli@0.3.8
Patch Changes
weak-node-api@0.0.2
Patch Changes
Note
Version packages, introduce standalone
weak-node-api, adoptfind_package, and add Apple bundle identifier support/escaping across tools and host.weak-node-apiinto standalone package (weak-node-api@0.0.2) and switch consumers tofind_package-based discovery; update deps/peers accordingly.react-native-node-api@0.7.0):find_package; stop exportingweakNodeApiPath.--apple-bundle-identifier; includeapple/in package; adjust Hermes vendoring guidance.cmake-rn@0.6.0: add--apple-bundle-identifier; usefind_package.gyp-to-cmake@0.5.0: usefind_package.ferric-cli@0.3.8: add--apple-bundle-identifier; update deps.packages/weak-node-apiwith build scripts and headers; bumpnode-teststoreact-native-node-api@^0.7.0; remove consumed changesets.Written by Cursor Bugbot for commit 144f262. This will update automatically on new commits. Configure here.