Merged
Conversation
kraenhansen
added
Apple 🍎
kraenhansen
force-pushed
the
kh/target-renamed
branch
from
384c1ad to
a5aef5e
Compare
kraenhansen
force-pushed
the
kh/target-renamed
branch
from
a5aef5e to
3839c3a
Compare
Collaborator
Author
|
Merging to keep the PR stacking manageable, please review in retrospect 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I renamed
triplettotargetin #189, mainly to converge with the naming used in Ferric (inheriting--targetfrom the Rust compiler).I'm backtracking on that decision, because in the context of CMake, developers expect to be able to pass a
--targetto declare the CMake target they want to build.The idea of a triplet (used even in the case of four names separated by dashes) is used by vspkg for the concept were interested in capturing: https://learn.microsoft.com/da-dk/vcpkg/users/triplets and the Rust compiler documentation use "target triplets" for the same concept.
Merging this PR will:
cmake-rnto use a platform abstraction #189).