fix: copy guarded require properties safely - #1435
Open
yellowbeee wants to merge 3 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 94c8ac8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@yellowbeee is attempting to deploy a commit to the Callstack Team on Vercel. A member of the Team first needs to authorize it. |
Collaborator
|
Hey thanks for your pr 🙏. Was wondering if you can help describe the issue it solves a bit mode. Do we have an issue for the bug it fixes? How to reproduce that problem? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__webpack_require__runtime properties using their descriptorsProblem
The guarded require runtime assigns every own property from the original require function directly to its wrapper. When the runtime is emitted inside a strict-mode bundle, assigning read-only Function properties such as
lengthornamethrows before the React Native application entry can run.Descriptor copying also avoids evaluating runtime getters while the wrapper is being initialized and preserves their original enumerability and accessors.
Test plan
pnpm --filter @callstack/repack test -- guardedRequire.test.ts --runInBandpnpm --filter @callstack/repack typecheckpnpm exec biome check packages/repack/src/plugins/RepackTargetPlugin/implementation/guardedRequire.ts packages/repack/src/plugins/RepackTargetPlugin/implementation/__tests__/guardedRequire.test.ts