feat: add configurable results directory - #592
Open
huytdps13400 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The result directory was hardcoded independently in the CLI, measure, and compare packages. Changing only the CLI path would still leave compare reading the original .reassure files, so the environment contract is resolved at all three package boundaries.
Testing
The new tests were observed failing before the implementation:
Validation after the change:
I also ran the built CLI end to end on Node 24 with a no-op test runner. Baseline followed by current measurement created baseline.perf, current.perf, output.json, and output.md only inside the configured package-specific directory.
Fixes #569.