fix cleanup of waitFor timers when an error occurs during onTimeout printout#1918
Open
ggilles wants to merge 11 commits into
Open
fix cleanup of waitFor timers when an error occurs during onTimeout printout#1918ggilles wants to merge 11 commits into
ggilles wants to merge 11 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1918 +/- ##
==========================================
+ Coverage 98.40% 98.42% +0.02%
==========================================
Files 79 79
Lines 1501 1521 +20
Branches 414 401 -13
==========================================
+ Hits 1477 1497 +20
Misses 24 24 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt at fixing the timer cleanup bug described in #1917.
Summary
There are 2 fixes in there:
Test plan
I included tests for both cases explained above. Very new to this codebase, so I'm not sure I'm doing it correctly. Forgive me is isn't suitable 🙏 .