feat: add typed leading and trailing slots to List.Item - #5042
Draft
adam-sajko wants to merge 5 commits into
Draft
feat: add typed leading and trailing slots to List.Item#5042adam-sajko wants to merge 5 commits into
adam-sajko wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#4930 wants explicit slots instead of layout tied to render props. Right now
leftandrighthand the caller astyleobject and acolorand trust them to apply both, soList.Itemdoes not really own its own layout.Related issue
Related to #4930 and #4976
Draft, blocked on #5018. Two things I would like your call on:
List.Itemhandlesleftandright. Since v6 alpha allows breaking changes without deprecation aliases, should the final version just dropleftandright?leadingandtrailingthe naming you want, orleadingAccessoryandtrailingAccessory, or oneslotsobject?Stacked on the three line padding PR for later. These are stacked, and since a fork branch cannot be used as the base of a cross fork PR, the commits from the PRs below are shown here until they are merged.
Test plan
Unit tests.