refactor: align List tokens, spacing and typography with MD3 - #5041
Draft
adam-sajko wants to merge 1 commit into
Draft
refactor: align List tokens, spacing and typography with MD3#5041adam-sajko wants to merge 1 commit into
adam-sajko wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
List.ItemandList.AccordionhardcodedfontSize16 and 14 and never passed a variant, soTextfell back totheme.fonts.defaultand the platform decided the line height. Item heights were not deterministic.Vertical spacing was also split in two,
paddingVertical: 8on the container plusmarginVertical: 6on the row. That adds up to 14dp, which is right for a two line item and wrong for a one line one.The
titleanddescriptionrender props still getfontSize, now read fromtheme.fonts. Same values as before, 16 and 14.No API changes!
Related issue
Related to #4976
Test plan
Snapshots were updated on purpose.