refactor: add color role table and buildScheme#4916
Open
adrcotfas wants to merge 1 commit into@adrcotfas/refactor/structurefrom
Open
refactor: add color role table and buildScheme#4916adrcotfas wants to merge 1 commit into@adrcotfas/refactor/structurefrom
adrcotfas wants to merge 1 commit into@adrcotfas/refactor/structurefrom
Conversation
Adds src/theme/tokens/sys/color/roles.ts with a roleToTone table keyed by (mode, contrast) and a buildScheme() function. LightTheme and DarkTheme replace their hand-duplicated color literals with a single buildScheme() call each. Output shape is identical; tone values match the existing hand-written spec.
|
The mobile version of example app from this branch is ready! You can see it here. |
This was referenced May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
LightThemeandDarkThemeeach contained ~70 lines of hand-duplicated palette look-ups. Because the mapping between color roles (e.g.primary) and palette tones (e.g.primary40) isdefined by the Material Design 3 spec, keeping it as inlined object literals meant every future scheme (high-contrast, dynamic) would require copy-pasting the same structure again with no single source of truth to audit against the spec.
This extracts that spec knowledge into a
roleToTonetable insrc/theme/tokens/sys/color/roles.ts, keyed by(mode, contrast). AbuildScheme()function walks the table, resolves palettevalues, and derives the computed fields (
stateLayerPressed,elevation).LightThemeandDarkThemenow each callbuildScheme()with a single argument instead of listing ~60 literals.No behavior changes: the output shape is identical and every tone value matches the previous hand-written spec.
Related issue
See https://www.notion.so/callstack/React-Native-Paper-Foundation-for-MD3-Expressive-34c5d027c0f880edba3df107cd35946f?source=copy_link
refactor: remove MD3 prefix and use deprecated aliases #4910
refactor: move styles/ into src/theme/ tree #4915
refactor: add color role table and buildScheme #4916
feat: add theme.state opacity tokens and split theme types #4917
feat: add theme.shapes and cornersToStyle #4919
feat: add emphasized typescale and fix letter-spacing spec bugs #4920
feat: add motion tokens (spring, easing, duration) #4922
feat: add elevation tokens and fix Android dp spec bug #4923
Test plan
yarn typescript-- no new type errorsyarn test-- all existing snapshot and unit tests pass; color values are unchanged