feat: strip SO files by default, deprecate experimental option in favor of useStrippedSoFiles#326
Open
artus9033 wants to merge 2 commits into
Open
feat: strip SO files by default, deprecate experimental option in favor of useStrippedSoFiles#326artus9033 wants to merge 2 commits into
artus9033 wants to merge 2 commits into
Conversation
…or of useStrippedSoFiles
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the React Native Brownfield Gradle plugin configuration to make using stripped native .so files the default behavior, while keeping backward compatibility by deprecating the old experimentalUseStrippedSoFiles flag in favor of useStrippedSoFiles.
Changes:
- Introduces
useStrippedSoFiles(defaulting totrue) and deprecatesexperimentalUseStrippedSoFilesas an alias. - Updates JNI libs processing to read the new
useStrippedSoFilesproperty. - Adds a changeset documenting the behavior change and deprecation.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| gradle-plugins/react/example-android-library/build.gradle.kts | Removes a stray line from the example library Gradle build file. |
| gradle-plugins/react/brownfield/src/main/kotlin/com/callstack/react/brownfield/utils/Extension.kt | Adds useStrippedSoFiles (default true) and deprecates experimentalUseStrippedSoFiles via delegation. |
| gradle-plugins/react/brownfield/src/main/kotlin/com/callstack/react/brownfield/processors/JNILibsProcessor.kt | Switches the gating flag from experimentalUseStrippedSoFiles to useStrippedSoFiles. |
| .changeset/frank-chairs-grin.md | Declares a minor release documenting the default behavior change and deprecation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
54
to
58
| val jniDir = archiveLibrary.getJniDir() | ||
| processNestedLibs(jniDir.listFiles(), existingJNILibs) | ||
| if (projectExt.experimentalUseStrippedSoFiles) { | ||
| if (projectExt.useStrippedSoFiles) { | ||
| copyStrippedSoLibs(variant, existingJNILibs) | ||
| } else { |
Collaborator
Author
There was a problem hiding this comment.
We may address this in a follow-up PR.
CC @hurali97
krozniata
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR:
experimentalUseStrippedSoFilesin favor ofuseStrippedSoFilesuseStrippedSoFilesistrueby default (experimentalUseStrippedSoFilesused to befalseby default)Test plan
CI green.