chore: ESLint overhaul

apps/RNApp/eslint.config.mjs

@@ -0,0 +1,4 @@
+import eslintRnConfig from '../../eslint.config.rn.mjs';
+
+/** @type {import('eslint').Linter.Config[]} */
+export default eslintRnConfig;

apps/RNApp/metro.config.js

@@ -1,5 +1,5 @@
+const path = require('node:path');
 const { getDefaultConfig, mergeConfig } = require('@react-native/metro-config');
-const path = require('path');
 
 const root = path.resolve(__dirname, '..', '..');
 

apps/RNApp/package.json

@@ -40,7 +40,9 @@
     "@types/jest": "^29.5.13",
     "@types/react": "^19.1.1",
     "@types/react-test-renderer": "^19.1.0",
-    "eslint": "^8.19.0",
+    "eslint": "^9.28.0",
+    "globals": "^16.2.0",
+    "import": "^0.0.6",
     "jest": "^29.6.3",
     "prettier": "2.8.8",
     "react-native-safe-area-context": "^5.3.0",

apps/RNApp/react-native.config.js

@@ -1,4 +1,4 @@
-const path = require('path');
+const path = require('node:path');
 const pkg = require('../../packages/react-native-brownfield/package.json');
 
 module.exports = {

apps/TesterIntegrated/App.tsx

@@ -1,13 +1,14 @@
+import { useStore } from '@callstack/brownie';
 import { useEffect } from 'react';
+import './BrownfieldStore.brownie';
 import { StyleSheet, Text, View, Button, TextInput } from 'react-native';
-import { useStore } from '@callstack/brownie';
+
 import {
   createNativeStackNavigator,
   type NativeStackScreenProps,
 } from '@react-navigation/native-stack';
 import ReactNativeBrownfield from '@callstack/react-native-brownfield';
 import { NavigationContainer } from '@react-navigation/native';
-import './BrownfieldStore.brownie';
 
 const getRandomValue = () => Math.round(Math.random() * 255);
 const getRandomTheme = () => {

apps/TesterIntegrated/eslint.config.mjs

@@ -0,0 +1,4 @@
+import eslintRnConfig from '../../eslint.config.rn.mjs';
+
+/** @type {import('eslint').Linter.Config[]} */
+export default eslintRnConfig;

apps/TesterIntegrated/metro.config.cjs

@@ -1,4 +1,4 @@
-const path = require('path');
+const path = require('node:path');
 const { getDefaultConfig } = require('@react-native/metro-config'); // Import from `@expo/metro-config` if using Expo CLI
 const { withMetroConfig } = require('react-native-monorepo-config');
 

apps/TesterIntegrated/package.json

@@ -6,7 +6,8 @@
     "start": "react-native start",
     "build:tester-integrated:android": "cd kotlin && ./gradlew assembleDebug",
     "build:tester-integrated:ios": "cd swift && xcodebuild -workspace SwiftExample.xcworkspace -scheme SwiftExample -configuration Release -sdk iphonesimulator build CODE_SIGNING_ALLOWED=NO -derivedDataPath ./build",
-    "brownfield:codegen": "brownfield codegen"
+    "brownfield:codegen": "brownfield codegen",
+    "lint": "eslint ."
   },
   "dependencies": {
     "@callstack/brownie": "*",
@@ -30,6 +31,7 @@
     "@react-native/metro-config": "0.82.1",
     "@react-native/typescript-config": "0.82.1",
     "@types/react": "^19.1.1",
+    "eslint": "^9.28.0",
     "react-native-monorepo-config": "^0.3.1"
   },
   "engines": {

apps/TesterIntegrated/react-native.config.js

@@ -1,4 +1,4 @@
-const path = require('path');
+const path = require('node:path');
 const brownfieldPkg = require('../../packages/react-native-brownfield/package.json');
 const browniePkg = require('../../packages/brownie/package.json');
 

eslint.config.base.mjs

@@ -0,0 +1,42 @@
+import prettier from 'eslint-plugin-prettier';
+import eslintConfigPrettier from 'eslint-config-prettier';
+import eslintPluginNodeImport from 'eslint-plugin-node-import';
+
+/**
+ * ESLint base configuration shared for other re-usable configs
+ * @type {import('eslint').Linter.Config[]}
+ */
+export default [
+  {
+    ignores: [
+      '**/node_modules/**',
+      '**/lib/**',
+      '**/dist/**',
+      '**/build/**',
+      '**/.turbo/**',
+      '**/.cxx/**',
+      '**/Pods/**',
+    ],
+  },
+
+  // below: prettier integration
+  eslintConfigPrettier,
+  {
+    plugins: {
+      prettier,
+    },
+    rules: {
+      'prettier/prettier': 'error',
+    },
+  },
+
+  // below: enforce importing of built-in Node.js modules with the 'node:' prefix
+  {
+    plugins: {
+      'node-import': eslintPluginNodeImport,
+    },
+    rules: {
+      'node-import/prefer-node-protocol': 'error',
+    },
+  },
+];

eslint.config.rn.mjs

@@ -0,0 +1,28 @@
+import globals from 'globals';
+import { fixupConfigRules } from '@eslint/compat';
+import { FlatCompat } from '@eslint/eslintrc';
+
+import baseEslintConfig from './eslint.config.base.mjs';
+
+const flatCompat = new FlatCompat();
+
+/**
+ * ESLint configuration for React Native packages in the monorepo
+ * @type {import('eslint').Linter.Config[]}
+ */
+export default [
+  ...fixupConfigRules(flatCompat.extends('@react-native/eslint-config')),
+  ...baseEslintConfig,
+  {
+    languageOptions: {
+      ecmaVersion: 'latest',
+      sourceType: 'module',
+      globals: {
+        ...globals.node,
+      },
+    },
+    rules: {
+      '@typescript-eslint/no-require-imports': 'off',
+    },
+  },
+];

eslint.config.ts.mjs

@@ -0,0 +1,25 @@
+import tseslint from 'typescript-eslint';
+
+import baseEslintConfig from './eslint.config.base.mjs';
+
+/**
+ * ESLint configuration for JS/TS packages in the monorepo
+ * @type {import('eslint').Linter.Config[]}
+ */
+export default [
+  ...baseEslintConfig,
+
+  // below: tseslint integration
+  ...tseslint.configs.recommended,
+  {
+    rules: {
+      '@typescript-eslint/no-empty-object-type': [
+        'error',
+        {
+          allowInterfaces: 'always',
+        },
+      ],
+      '@typescript-eslint/no-explicit-any': 'warn',
+    },
+  },
+];

package.json

@@ -39,15 +39,21 @@
   "devDependencies": {
     "@commitlint/cli": "^20.1.0",
     "@commitlint/config-conventional": "^20.0.0",
-    "@react-native/eslint-config": "0.82.1",
+    "@eslint/compat": "^2.0.1",
+    "@react-native/eslint-config": "^0.83.1",
     "babel-plugin-module-resolver": "5.0.2",
-    "eslint": "^8.57.1",
+    "eslint": "^9.28.0",
     "eslint-config-prettier": "^10.1.8",
-    "eslint-plugin-prettier": "^5.1.3",
+    "eslint-plugin-node-import": "^1.0.5",
+    "eslint-plugin-prettier": "^5.4.0",
+    "eslint-plugin-react": "^7.37.5",
+    "eslint-plugin-react-hooks": "^5.2.0",
+    "globals": "^16.2.0",
     "lefthook": "^2.0.3",
     "prettier": "^3.5.3",
     "turbo": "^2.7.3",
-    "typescript": "5.8.3"
+    "typescript": "5.8.3",
+    "typescript-eslint": "^8.53.0"
   },
   "commitlint": {
     "extends": [

packages/brownie/eslint.config.mjs

@@ -0,0 +1,4 @@
+import eslintRnConfig from '../../eslint.config.rn.mjs';
+
+/** @type {import('eslint').Linter.Config[]} */
+export default eslintRnConfig;

packages/brownie/package.json

@@ -28,7 +28,7 @@
     "./package.json": "./package.json"
   },
   "scripts": {
-    "lint": "eslint \"**/*.{js,ts,tsx}\"",
+    "lint": "eslint .",
     "typecheck": "tsc --noEmit",
     "build": "bob build",
     "dev": "nodemon --watch src --ext js,ts,json --exec \"bob build\""
@@ -72,10 +72,11 @@
     "@babel/preset-typescript": "^7.27.1",
     "@babel/runtime": "^7.25.0",
     "@react-native/babel-preset": "0.82.1",
-    "@react-native/eslint-config": "0.82.1",
     "@types/node": "^22.0.0",
     "@types/react": "^19.1.1",
-    "eslint": "^8.57.1",
+    "eslint": "^9.28.0",
+    "globals": "^16.2.0",
+    "import": "^0.0.6",
     "nodemon": "^3.1.11",
     "react": "19.1.1",
     "react-native": "0.82.1",

packages/brownie/src/index.ts

@@ -11,16 +11,18 @@ export interface BrownieStore {}
 
 type StoreListener = () => void;
 
+type HostObject = any;
+
 interface StoreCache {
-  hostObject: any;
+  hostObject: HostObject;
   snapshot: Record<string, unknown>;
   listeners: Set<StoreListener>;
 }
 
 const stores = new Map<string, StoreCache>();
 
-function getHostObject(key: string): any {
-  // @ts-ignore
+function getHostObject(key: string): HostObject {
+  // @ts-expect-error - untyped global prop set by BrownieInstaller.cpp
   return global.__getStore?.(key);
 }
 

packages/cli/eslint.config.mjs

@@ -0,0 +1,4 @@
+import eslintBaseConfig from '../../eslint.config.base.mjs';
+
+/** @type {import('eslint').Linter.Config[]} */
+export default eslintBaseConfig;

packages/cli/package.json

@@ -20,7 +20,7 @@
     "./package.json": "./package.json"
   },
   "scripts": {
-    "lint": "eslint \"**/*.{js,ts,tsx}\"",
+    "lint": "eslint .",
     "typecheck": "tsc --noEmit",
     "build": "tsc -p tsconfig.json",
     "dev": "tsc -p tsconfig.json --watch",
@@ -68,13 +68,13 @@
     "@babel/preset-typescript": "^7.28.5",
     "@react-native-community/cli-types": "^20.0.0",
     "@react-native/babel-preset": "0.82.1",
-    "@react-native/eslint-config": "0.82.1",
     "@types/babel__core": "^7",
     "@types/babel__preset-env": "^7",
     "@types/lodash.clonedeep": "^4.5.9",
     "@types/node": "^25.0.3",
     "@vitest/coverage-v8": "^4.0.17",
-    "eslint": "^8.57.1",
+    "eslint": "^9.28.0",
+    "globals": "^16.2.0",
     "nodemon": "^3.1.11",
     "typescript": "5.8.3",
     "vitest": "^4.0.17"

packages/cli/src/brownfield/commands/packageAndroid.ts

@@ -1,17 +1,17 @@
-import { packageAarAction } from '@rock-js/plugin-brownfield-android';
+import { Command } from 'commander';
+
 import {
-  packageAarOptions,
   type PackageAarFlags,
+  packageAarOptions,
 } from '@rock-js/platform-android';
+import { packageAarAction } from '@rock-js/plugin-brownfield-android';
 
-import { Command } from 'commander';
-
-import { getProjectInfo } from '../utils/index.js';
 import {
+  ExampleUsage,
   actionRunner,
   curryOptions,
-  ExampleUsage,
 } from '../../shared/index.js';
+import { getProjectInfo } from '../utils/index.js';
 
 export const packageAndroidCommand = curryOptions(
   new Command('package:android').description('Build Android AAR'),

packages/cli/src/brownie/__tests__/commands/codegen.test.ts

@@ -1,12 +1,12 @@
-import fs from 'fs';
-import path from 'path';
-import { fileURLToPath } from 'url';
+import fs from 'node:fs';
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
 import { describe, it, expect, beforeEach, afterEach, vi, Mock } from 'vitest';
+import * as rockTools from '@rock-js/tools';
 import { runCodegen } from '../../commands/codegen.js';
 import * as swiftGenerator from '../../generators/swift.js';
 import * as kotlinGenerator from '../../generators/kotlin.js';
 import * as storeDiscovery from '../../store-discovery.js';
-import * as rockTools from '@rock-js/tools';
 
 const __dirname = path.dirname(fileURLToPath(import.meta.url));
 const FIXTURES_DIR = path.join(__dirname, '../../__fixtures__');

packages/cli/src/brownie/__tests__/config.test.ts

@@ -1,7 +1,8 @@
+import { fileURLToPath } from 'node:url';
 import fs from 'node:fs';
 import path from 'node:path';
-import { fileURLToPath } from 'node:url';
-import { describe, it, expect, afterEach, vi } from 'vitest';
+
+import { afterEach, describe, expect, it, vi } from 'vitest';
 
 import { loadConfig } from '../config.js';
 

packages/cli/src/brownie/__tests__/store-discovery.test.ts

@@ -1,6 +1,6 @@
-import fs from 'fs';
-import path from 'path';
-import { fileURLToPath } from 'url';
+import fs from 'node:fs';
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
 import { describe, it, expect, afterEach } from 'vitest';
 import { discoverStores } from '../store-discovery.js';
 

packages/cli/src/brownie/commands/codegen.ts

@@ -3,14 +3,14 @@ import { styleText } from 'node:util';
 
 import { Command, Option } from 'commander';
 
+import { intro, logger, outro } from '@rock-js/tools';
+import { QuickTypeError } from 'quicktype-core';
 import { actionRunner } from '../../shared/index.js';
 import { loadConfig, type BrownieConfig } from '../config.js';
 import { generateSwift } from '../generators/swift.js';
 import { generateKotlin } from '../generators/kotlin.js';
 import { discoverStores, type DiscoveredStore } from '../store-discovery.js';
 import { Platform } from '../types.js';
-import { intro, logger, outro } from '@rock-js/tools';
-import { QuickTypeError } from 'quicktype-core';
 
 function getOutputPath(dir: string, name: string, ext: string): string {
   return path.join(dir, `${name}.${ext}`);

packages/cli/src/brownie/config.ts

@@ -1,5 +1,5 @@
-import fs from 'fs';
-import path from 'path';
+import fs from 'node:fs';
+import path from 'node:path';
 
 export interface BrownieConfig {
   swift?: string;