Skip to content

Embed app logo in email templates - #441

Merged
jbrooksuk merged 2 commits into
mainfrom
codex/embed-email-logo
Aug 22, 2026
Merged

Embed app logo in email templates#441
jbrooksuk merged 2 commits into
mainfrom
codex/embed-email-logo

Conversation

@jbrooksuk

Copy link
Copy Markdown
Member

Summary

  • embed the configured app logo in outgoing emails as an inline CID attachment
  • add configurable upload disk, maximum size, and accepted image MIME types
  • apply the configured disk consistently to uploads, status-page rendering, and email attachments
  • add regression coverage for existing stored logos and upload validation

Configuration

  • CACHET_UPLOAD_DISK (default: public)
  • CACHET_UPLOAD_MAX_SIZE (default: 1024 KB)
  • CACHET_UPLOAD_IMAGE_MIME_TYPES (default: JPEG, PNG, GIF, and WebP)

Existing uploaded logos remain compatible because the disk defaults to the previously hard-coded public disk and the stored path format is unchanged.

Verification

  • 1,041 tests passed, 2 todos
  • Pint passed
  • PHPStan passed with no errors
  • frontend build passed
  • git diff --check passed

Closes #436

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃挕 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6cf63454cf

鈩癸笍 About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 馃憤.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/View/Composers/MailThemeComposer.php Outdated
@jbrooksuk
jbrooksuk merged commit 9183688 into main Aug 22, 2026
23 checks passed
@jbrooksuk
jbrooksuk deleted the codex/embed-email-logo branch August 22, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EMail Notifications : No Custom Image?

1 participant