Skip to content

Expand architecture and core behavior tests - #440

Merged
jbrooksuk merged 1 commit into
mainfrom
codex/add-missing-tests
Aug 22, 2026
Merged

Expand architecture and core behavior tests#440
jbrooksuk merged 1 commit into
mainfrom
codex/add-missing-tests

Conversation

@jbrooksuk

Copy link
Copy Markdown
Member

Summary

  • fix CommandsTest so it targets the real Cachet\Commands namespace
  • add Pest architecture coverage for filters, MCP tools, notifications, query builders, renderers, and settings
  • add behavioral coverage for webhook dispatch, flexible date casting, and model metadata lifecycle

Testing

  • php84 -d memory_limit=512M vendor/bin/pest tests/Architecture tests/Unit/Actions/Webhook/DispatchWebhooksTest.php tests/Unit/Data/FlexibleDateTimeCastTest.php tests/Unit/Models/HasMetaTest.php --compact (38 passed, 78 assertions)
  • php84 vendor/bin/pint --test tests/Architecture tests/Unit/Actions/Webhook/DispatchWebhooksTest.php tests/Unit/Data/FlexibleDateTimeCastTest.php tests/Unit/Models/HasMetaTest.php
  • Full suite attempted: 986 passed and 2 todo; 49 rendering tests fail because the Testbench fixture cannot find its published Vite manifest.

@jbrooksuk
jbrooksuk marked this pull request as ready for review August 22, 2026 10:51
@jbrooksuk
jbrooksuk merged commit 14193bc into main Aug 22, 2026
23 checks passed
@jbrooksuk
jbrooksuk deleted the codex/add-missing-tests branch August 22, 2026 10:51

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃挕 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b99a8bc8cc

鈩癸笍 About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 馃憤.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/Architecture/RenderersTest.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant