Stop Cachet API routes inheriting the host application rate limiter#375
Merged
Conversation
The API routes were registered with both the "cachet:api" middleware group and "throttle:cachet-api". The "cachet:api" group defaulted to the host application's "api" middleware group, which typically registers its own "throttle:api" limiter (Laravel's default is 60 requests a minute). Both throttles were applied, so the more restrictive host limiter capped requests at 60 and its value was reported in the X-RateLimit-Limit header, ignoring both the CACHET_API_RATE_LIMIT setting and the intended default of 300. Default "cachet.api_middleware" to SubstituteBindings only, so Cachet's API relies solely on its own "throttle:cachet-api" limiter while keeping route model binding working. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TKAFhcTL68GptC9YTU2qi9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #311
The API routes were registered with both the "cachet:api" middleware
group and "throttle:cachet-api". The "cachet:api" group defaulted to the
host application's "api" middleware group, which typically registers its
own "throttle:api" limiter (Laravel's default is 60 requests a minute).
Both throttles were applied, so the more restrictive host limiter capped
requests at 60 and its value was reported in the X-RateLimit-Limit
header, ignoring both the CACHET_API_RATE_LIMIT setting and the intended
default of 300.
Default "cachet.api_middleware" to SubstituteBindings only, so Cachet's
API relies solely on its own "throttle:cachet-api" limiter while keeping
route model binding working.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01TKAFhcTL68GptC9YTU2qi9