Draft
Conversation
Member
Author
|
Yep, I'm already noticing some comments and the like have been lost in the transition. This is going to need more work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #127, this PR migrates the core structure of the repo to something more similar to the polling crate. It does this by creating separate impls-per-target under
sys/, with a singlecfg-ifswitching on them in thesys/mod.rs:This general approach should result in fewer inline
cfgs and a better general separation of concerns. But it's somewhat unavoidable that we'll end up with different code paths for p2 and p3 since the underlying async model is different. Something will need to abstract over those differences, and typically that job lands on runtimes. Unless of course we don't want to support p3 inwstd, but if that's the case we should probably talk that over sync sometime.I'm putting this up as a draft because I generated this with an agent and haven't yet gone over this in detail. The changes are mostly mechanical though, so I don't expect much to be off. I prefer to review changes like these via the github interface, which is why I'm submitting this as-is. But like: please don't feel obliged to review this right now!