C++: sort types topologically before emitting definitions#1619
Merged
Conversation
Specifically, we sort the types while taking the parameter and return types of resource functions into consideration. This ensures that types are declared (and, if necessary, defined) before they are used in the emitted source code. Fixes bytecodealliance#1615
alexcrichton
approved these changes
May 27, 2026
alexcrichton
approved these changes
May 27, 2026
Merged
via the queue into
bytecodealliance:main
with commit May 27, 2026
d635117
56 of 58 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifically, we sort the types while taking the parameter and return types of resource functions into consideration. This ensures that types are declared (and, if necessary, defined) before they are used in the emitted source code.
Fixes #1615