DRAFT: fix(rust): sanitize export names for PGO compatibility#1577
Closed
carabistouflette wants to merge 2 commits intobytecodealliance:mainfrom
Closed
DRAFT: fix(rust): sanitize export names for PGO compatibility#1577carabistouflette wants to merge 2 commits intobytecodealliance:mainfrom
carabistouflette wants to merge 2 commits intobytecodealliance:mainfrom
Conversation
Replace ':' and '#' characters with underscores in export names to make them compatible with native ELF linkers during PGO builds. Fixes bytecodealliance#1509
Author
|
still a draft for now |
carabistouflette
changed the title
Author
|
The PGO issue with native ELF linkers cannot be solved purely in wit-bindgen because the component model metadata encoding is controlled by wasm-tools apparently. Sad, I'll close the PR as it's not of any use |
Author
|
I'll do another PR trying to fix the issue on both end as it needs a change in wit-bindgen and also in wasm-tools |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace ':' and '#' characters with underscores in export names to make them compatible with native ELF linkers during PGO builds.
Fixes #1509