Skip to content

Adapter to impl futures::Stream#1575

Merged
alexcrichton merged 3 commits intobytecodealliance:mainfrom
fibonacci1729:stream
Mar 31, 2026
Merged

Adapter to impl futures::Stream#1575
alexcrichton merged 3 commits intobytecodealliance:mainfrom
fibonacci1729:stream

Conversation

@fibonacci1729
Copy link
Copy Markdown
Contributor

This PR adds a futures::Stream adapter (gated on the futures-stream feature) allowing the conversion from RawStreamReader into RawStreamReaderStream which implements futures::Stream.

Signed-off-by: Brian Hardock <brian.hardock@fermyon.com>
@fibonacci1729 fibonacci1729 marked this pull request as ready for review March 31, 2026 17:37
Copy link
Copy Markdown
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Mind putting this in a mod futures_stream; or similar to avoid the extra #[cfg]?

@alexcrichton
Copy link
Copy Markdown
Member

Also, can you add some CI configuration and/or a test to ensure this builds?

Signed-off-by: Brian Hardock <brian.hardock@fermyon.com>
@fibonacci1729
Copy link
Copy Markdown
Contributor Author

fibonacci1729 commented Mar 31, 2026

@alexcrichton I moved the code into futures_stream.rs, added a build check in main.yml, and a test tests/runtime-async/async/stream-to-futures-stream.

Signed-off-by: Brian Hardock <brian.hardock@fermyon.com>
@alexcrichton alexcrichton added this pull request to the merge queue Mar 31, 2026
Merged via the queue into bytecodealliance:main with commit e5c8ce6 Mar 31, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants