wasmtime-cache: Reject overflowing duration values - #14060
Open
racequite wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cache configuration duration deserializer uses unchecked multiplication when converting minutes, hours, and days to seconds. Oversized values therefore panic when overflow checks are enabled and wrap otherwise. For example,
307445734561825861mwraps to 44 seconds in a release build and is then accepted by configuration validation.Use
u64::checked_mulfor the affected units so overflow is reported through the existing invalid-configuration path. Add regression coverage for the first overflowing minute, hour, and day values.