validate content-length is decimal digits in wasi-http#13636
Open
netliomax25-code wants to merge 1 commit into
Open
validate content-length is decimal digits in wasi-http#13636netliomax25-code wants to merge 1 commit into
netliomax25-code wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_content_lengthand the p3parse_header_valuereadContent-Lengthwithu64'sFromStr, which also accepts a leading+, so a value like+5is parsed as5.1*DIGIT, so a value like that is accepted here while a strict parser (a proxy or the peer) would reject it. The parsed value drives the p2 and p3 request/response body framing, andparse_header_valueruns when a guest builds a field map.Reject any
content-lengthvalue that is not a non-empty run of ASCII decimal digits before parsing, at both sites. Added unit tests covering+5,-5, a leading space, and the empty value.