Skip to content

Move most module initialization to compiled code #13487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexcrichton merged 4 commits into from
May 28, 2026
Merged

Move most module initialization to compiled code #13487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5ad8ce4
Don't panic in `Slab::{get,get_mut}`
alexcrichton May 26, 2026
5c4905d
Don't allow memset with funcref arrays
alexcrichton May 26, 2026
edb8de0
Move most module initialization to compiled code
alexcrichton May 26, 2026
1f3f64a
Review comments
alexcrichton May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 6 additions & 14 deletions crates/core/src/slab.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,15 +390,11 @@ impl<T> Slab<T> {
///
/// Returns `None` if the value has since been deallocated.
///
/// If `id` comes from a different `Slab` instance, this method may panic,
/// return `None`, or return an arbitrary value.
/// If `id` comes from a different `Slab` instance, this method may return
/// `None`, or return an arbitrary value.
#[inline]
pub fn get(&self, id: Id) -> Option<&T> {
match self
.entries
.get(id.0.index())
.expect("id from different slab")
{
match self.entries.get(id.0.index())? {
Entry::Occupied(x) => Some(x),
Entry::Free { .. } => None,
}
Expand All @@ -408,15 +404,11 @@ impl<T> Slab<T> {
///
/// Returns `None` if the value has since been deallocated.
///
/// If `id` comes from a different `Slab` instance, this method may panic,
/// return `None`, or return an arbitrary value.
/// If `id` comes from a different `Slab` instance, this method may return
/// `None`, or return an arbitrary value.
#[inline]
pub fn get_mut(&mut self, id: Id) -> Option<&mut T> {
match self
.entries
.get_mut(id.0.index())
.expect("id from different slab")
{
match self.entries.get_mut(id.0.index())? {
Entry::Occupied(x) => Some(x),
Entry::Free { .. } => None,
}
Expand Down
Loading
Loading