Skip to content

CI: Add a check for cranelift-codegen (only x86 and aarch64) on no_std tagets#12812

Merged
cfallin merged 5 commits intobytecodealliance:mainfrom
the-ssd:main
Mar 24, 2026
Merged

CI: Add a check for cranelift-codegen (only x86 and aarch64) on no_std tagets#12812
cfallin merged 5 commits intobytecodealliance:mainfrom
the-ssd:main

Conversation

@the-ssd
Copy link
Copy Markdown
Contributor

@the-ssd the-ssd commented Mar 20, 2026

This PR add a check in CI so that there aren't any regressions in the future.
Closes #1158. This was possible after #12596.

the-ssd added 2 commits March 20, 2026 22:19
CI: Add a check for cranelift-codegen (only x86 and aarch64) on no_std targets
@the-ssd the-ssd requested a review from a team as a code owner March 20, 2026 21:26
@the-ssd the-ssd requested review from rvolosatovs and removed request for a team March 20, 2026 21:26
Copy link
Copy Markdown
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexcrichton alexcrichton added this pull request to the merge queue Mar 21, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 21, 2026
@the-ssd the-ssd requested a review from a team as a code owner March 23, 2026 17:37
@the-ssd the-ssd requested review from fitzgen and removed request for a team March 23, 2026 17:37
@the-ssd
Copy link
Copy Markdown
Contributor Author

the-ssd commented Mar 23, 2026

Added a new commit, without it there are unused imports. This happens when building without unwind, this PR also covers that too.

@cfallin
Copy link
Copy Markdown
Member

cfallin commented Mar 23, 2026

Thanks! Can you rustfmt? Then this will be ready to merge I think.

@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:area:aarch64 Issues related to AArch64 backend. labels Mar 23, 2026
@cfallin cfallin enabled auto-merge March 24, 2026 20:53
@cfallin cfallin added this pull request to the merge queue Mar 24, 2026
Merged via the queue into bytecodealliance:main with commit 0e51666 Mar 24, 2026
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cranelift:area:aarch64 Issues related to AArch64 backend. cranelift Issues related to the Cranelift code generator

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cranelift-codegen no longer builds with no_std

3 participants