Do not panic on host calls when CM concurrency support is disabled#12659
Merged
alexcrichton merged 2 commits intobytecodealliance:mainfrom Feb 25, 2026
Merged
Conversation
alexcrichton
approved these changes
Feb 24, 2026
Member
alexcrichton
left a comment
alexcrichton
left a comment
There was a problem hiding this comment.
Ah this was part of a recent refactor where these calls can't be skipped so they can't just return Ok(()) and work correctly. Can you add calls to self.enter_call_not_concurrent() and self.exit_call_not_concurrent() in the disabled case?
For a test for this, can you add a test with concurrency_supoprt disabled and a host call with a borrow<T> resource is done? I think it should panic and/or cause problems with the PR as-is, but if not I can help whip up a more involved test.
fitzgen
force-pushed
the
concurrency-disabled-host-call-panic
branch
from
57e29f0 to
1b13d60
Compare
alexcrichton
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.