Skip to content

Fixes potential issue in length handling in array.new (Wasm GC) #4943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
srberard wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Open

Fixes potential issue in length handling in array.new (Wasm GC) #4943

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions core/iwasm/interpreter/wasm_loader.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1330,7 +1330,8 @@ load_init_expr(WASMModule *module, const uint8 **p_buf, const uint8 *buf_end,

size =
sizeof(WASMArrayNewInitValues)
+ sizeof(WASMValue) * (uint64)len_val.i32;
+ sizeof(WASMValue)
* (uint64)(uint32)len_val.i32;
Comment on lines 1331 to +1334
if (!(array_init_values = loader_malloc(
Comment on lines 1331 to 1335
size, error_buf, error_buf_size))) {
goto fail;
Expand Down Expand Up @@ -1406,7 +1407,7 @@ load_init_expr(WASMModule *module, const uint8 **p_buf, const uint8 *buf_end,
error_buf, error_buf_size)) {
goto fail;
}
len = len_val.i32;
len = (uint32)len_val.i32;

cur_value.array_new_default.type_index = type_idx;
cur_value.array_new_default.length = len;
Expand Down
Loading