Add map component type regression test#107
Closed
yordis wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
yordis
commented
Jun 30, 2026
| fn assert_component(bytes: &[u8]) { | ||
| assert!(wasmparser::Parser::is_component(&bytes)); | ||
| wasmparser::Validator::new().validate_all(&bytes).unwrap(); | ||
| wasmparser::Validator::new_with_features(wasmparser::WasmFeatures::all()) |
Author
There was a problem hiding this comment.
is it ok to enable all, or d you prefer I find a way to opt-in for things? I rather make the whole thing to work in the testing, just in case turning things off causes issues that we didn't see as a whole
Author
|
After talking to @alexcrichton it was decided that we should close this for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--component-typepath for WIT map definitions now that the parser stack understands them.