chore: bump omni to pick up trailing-comma tolerance#30
Merged
Conversation
Picks up bytebase/omni#127 — the mongo parser now accepts a single trailing comma in argument lists (matching mongosh / JS ES2017+ behavior). With this bump, statements of the form `db.coll.find({…},).sort({…})` parse cleanly through gomongo instead of erroring with `expected ,, got ")"`. No gomongo source changes — go.mod / go.sum bump only. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
d-bytebase
approved these changes
May 9, 2026
There was a problem hiding this comment.
Pull request overview
Bumps github.com/bytebase/omni to pick up upstream Mongo shell parser support for a single trailing comma in argument lists (mongosh / ES2017+ behavior), reducing fallbacks on otherwise-valid statements.
Changes:
- Update
github.com/bytebase/omnipseudo-version ingo.mod. - Refresh corresponding
go.sumentries for the updated omni version.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| go.mod | Bumps github.com/bytebase/omni to a newer pseudo-version that includes trailing-comma tolerance. |
| go.sum | Updates checksum entries to match the bumped omni version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The omni bump in the previous commit pulls in a transitive closure that requires Go ≥ 1.25.7. `go mod tidy` raises the main module's go directive accordingly, which CI verifies. Reverting it manually to 1.25.5 caused both the test job's tidy-diff check and the golangci-lint context loader to fail. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.com/bytebase/omnifromv0.0.0-20260402100940-de2123e1bfb3tov0.0.0-20260509021101-01140a7b9722.After this lands, gomongo will accept statements like:
Previously these failed with
expected ,, got ")". The wild gomongoFallback telemetry shows 6 such statements falling back to mongosh; all 6 now parse cleanly through gomongo with this bump.Changes
go.mod: omni version bumpgo.sum: hash updateNo gomongo source code changes.
Test plan
go build ./...cleango mod tidyproduces no further changes$sort: "-1"string-coercion issue at execution, which is expected and tracked separately)🤖 Generated with Claude Code