feat: Add F-Machine protocol for Gigolo BT-R#835
Open
penaltybush wants to merge 10 commits intobuttplugio:devfrom
Open
feat: Add F-Machine protocol for Gigolo BT-R#835penaltybush wants to merge 10 commits intobuttplugio:devfrom
penaltybush wants to merge 10 commits intobuttplugio:devfrom
Conversation
…ing to zero stops machine immediatly while speed is still bought down in the background.
Member
|
This is a really complicated protocol, and I need to get a new version of Intiface out ASAP, so this'll probably come in version after next. |
Author
That's completely fine. I'd rather you have time to review the submission. I've tested it but I don't know if I've followed this libraries best practices etc. |
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Complexity | 2 medium |
🟢 Metrics 26 complexity · 1 duplication
Metric Results Complexity 26 Duplication 1
TIP This summary will be updated as you push new changes. Give us feedback
Member
|
Ignore the codacy bot, not sure how that got added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is the F-Machine protocol implementation for the F-Machine Gigolo BT-R.
The same protocol is also used for the Tremblr BT-R and Alpha, however, they also have secondary functions for which there might not be good cmd mappings.
I have only added device config for the Gigolo at this time as all it's features are covered by this implementation.
Please let me know if there is anything you'd like me to change or anything extra that I need to include as part of this PR.