Rename unify.pm.issues to unify.ticketing.tickets#4
Conversation
Mirror the Unify API migration from the /pm/issues endpoint to /ticketing/tickets: - Rename lib/bundleup/unify/pm.rb -> ticketing.rb (PM class -> Ticketing, issues -> tickets, path pm/issues -> ticketing/tickets) - Update the require in lib/bundleup.rb and the client in unify.rb - Rename and update the spec, README, and examples Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014zVgT6VdGxc5a96oMxJU87
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d6dfc173c8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| class Ticketing < Base | ||
| # Fetches tickets from the connected ticketing tool. | ||
| def tickets(params = {}) | ||
| response = connection.get('ticketing/tickets') do |req| |
There was a problem hiding this comment.
Use the documented PM issues route
The current BundleUp Unified API docs still list the project-management operation as GET /v1/pm/issues (docs), with no ticketing/tickets route exposed. With this path, every call through BundleUp::Unify::Ticketing#tickets will request /v1/ticketing/tickets and fail for Jira/Linear connections (typically 404), so the SDK loses the existing issue-listing endpoint.
Useful? React with 👍 / 👎.
Mirrors the Unify API migration from the
/pm/issuesendpoint to/ticketing/tickets.Changes
lib/bundleup/unify/pm.rb→lib/bundleup/unify/ticketing.rb:PMclass →Ticketing,issues→tickets(pathpm/issues→ticketing/tickets)require_relativeinlib/bundleup.rband the client inlib/bundleup/unify.rb(@pm→@ticketing)spec/bundleup/unify/ticketing_spec.rb), plusunify_spec.rb, README, and examplesVerification
rspec— all 77 examples passscripts/check-sdk-parity.jsin the API repo reports no missingticketingnamespace file /ticketsmethod for this SDKNote
This SDK was already missing the
crmanddrivenamespaces and thechat.users/chat.message/git.branchesmethods relative to the canonical API surface. That drift is pre-existing and out of scope for this change.🤖 Generated with Claude Code
https://claude.ai/code/session_014zVgT6VdGxc5a96oMxJU87
Generated by Claude Code