Force bq.enter()/bq.leave() to be called if the scheduler is idle#153
Open
EdSchouten wants to merge 1 commit intomainfrom
Open
Force bq.enter()/bq.leave() to be called if the scheduler is idle#153EdSchouten wants to merge 1 commit intomainfrom
EdSchouten wants to merge 1 commit intomainfrom
Conversation
Once the final workers shut down, bq.enter()/bq.leave() won't end up getting called. This means that they only get removed from the scheduler the next time any RPC is called (e.g., when workers start to come online again). This unfortunately causes Prometheus metrics to be incorrect in the meantime.
EdSchouten
force-pushed
the
eschouten/20241129-force-cleanup
branch
from
ffa8729 to
1be1483
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once the final workers shut down, bq.enter()/bq.leave() won't end up getting called. This means that they only get removed from the scheduler the next time any RPC is called (e.g., when workers start to come online again). This unfortunately causes Prometheus metrics to be incorrect in the meantime.