[harmony] Bug 2051802: Abort UTF8 conversion without an explicit override - #177
Merged
Conversation
mrenvoize
approved these changes
Aug 3, 2026
mrenvoize
left a comment
Contributor
There was a problem hiding this comment.
This is good.. and it's actually slightly better than the corresponding 5.2 version in my opnion.
- 5.2 branch: kept the new ALLOW_UNSAFE_UTF8_CONVERSION/die logic nested inside the pre-existing if (!Bugzilla->installation_answers->{NO_PAUSE}) guard.
- Harmony: removes that outer NO_PAUSE gate entirely.
Member
Author
I don't see this? The 5.2 patch also gets rid of the outer NO_PAUSE gate. |
Contributor
I must be going mad.. I see it now too! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
When Docker hits the non-interactive UTF-8 conversion bailout, console output now prints a clear hint showing how to proceed explicitly:
BZ_ALLOW_UNSAFE_UTF8_CONVERSION=1 docker compose up
What changed
Net effect
Additional info
Test Plan
docker compose updocker compose downdocker compose upand verified that the conversion bailed with the new messaging.ALLOW_UNSAFE_UTF8_CONVERSION=1 docker compose upand verified that the conversion proceeded.