Skip to content

fix: don't panic on empty key when path enters an array #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
c-tonneslan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: don't panic on empty key when path enters an array #284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion parser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@ func searchKeys(data []byte, keys ...string) int {
}
case '[':
// If we want to get array element by index
if keyLevel == level && keys[level][0] == '[' {
if keyLevel == level && len(keys[level]) > 0 && keys[level][0] == '[' {
keyLen := len(keys[level])
// Note: keys[level][0] == '[' is guaranteed by the outer if-guard,
// so the former middle term `keys[level][0] != '['` was always false
Expand Down
12 changes: 12 additions & 0 deletions parser_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1170,6 +1170,18 @@ var getArrayTests = []GetTest{
isFound: true,
data: []string{`1`, `2`, `3`, `4`},
},
{
desc: `array with single empty-string key returns not-found, not panic`,
json: `[]`,
path: []string{""},
isFound: false,
},
{
desc: `truncated array with empty key returns not-found, not panic`,
json: `[`,
path: []string{""},
isFound: false,
},
{
desc: `read array of objects`,
json: `{"a": { "b":[{"x":1},{"x":2},{"x":3},{"x":4}]}}`,
Expand Down