Open
Conversation
anuejn
approved these changes
Jul 7, 2023
Member
anuejn
left a comment
anuejn
left a comment
There was a problem hiding this comment.
Seems good to me :)
Do you think we should to more testing before shipping this?
Member
Author
|
I'd prefer not to ship this with the 0.3.0, but once that is release, I'd be fine with merging it and then testing it on different plattforms |
Member
Author
|
Actually, there is one thing I noticed we have to fix before we can merge this: If I build an app locally and start it, it shows an error message about |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I only did preliminary testing (importing&transcribing, export), but it seems to work on my machine
This should hopefully massively reduce our build times